- From: Jungkee Song <notifications@github.com>
- Date: Thu, 07 Dec 2017 20:53:35 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 8 December 2017 04:53:58 UTC
jungkees commented on this pull request. > 1. If |client| is an [=environment settings object=], then: - 1. If |client| is not a <a>secure context</a>, continue to the next iteration of the loop. - 1. Else: - 1. If |client|’s <a>creation URL</a> is not a <a>potentially trustworthy URL</a>, continue to the next iteration of the loop. - 1. If |options|.{{ClientQueryOptions/includeUncontrolled}} is false, then: - 1. If |client|'s <a>active service worker</a> is not the associated [=ServiceWorkerGlobalScope/service worker=], continue to the next iteration of the loop. - 1. If |options|.{{ClientQueryOptions/includeReserved}} is false, then: - 1. If |client|'s [=environment/execution ready flag=] is unset, continue to the next iteration of the loop. + 1. If |client| is not a [=secure context=], [=continue=]. + 1. Otherwise: Nice cleanup! I think "Else" is better here for consistency though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1243#pullrequestreview-82066629
Received on Friday, 8 December 2017 04:53:58 UTC