- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 05 Dec 2017 23:46:41 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 5 December 2017 23:47:07 UTC
I see a few options: - Back out my GetMethod changes, pretend for a few days that we didn't notice this problem, and solve it ASAP. - Back out my GetMethod changes, rename our GetMethod to GetMethod2, open an issue to fix it, add a note in the spec pointing to that issue, and then merge this PR using GetMethod2 - Keep my GetMethod changes, and fix everything in this PR, probably including `size`. (The way I'd do that is by no longer doing the destructuring for the strategies, then maybe creating a mode for CreateAlgorithmFromUnderlyingMethod or a second abstract op, which can be used for both `start` and `size`.) WDYT? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/860#issuecomment-349479870
Received on Tuesday, 5 December 2017 23:47:07 UTC