- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 30 Aug 2017 17:36:02 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 31 August 2017 00:36:24 UTC
domenic commented on this pull request. About the name, I am trying to determine what it's actually used for. Maybe "CanCloseOrErrorOrEnqueue", but that's not really shorter or much better. I think an equivalent of this is already used in other places so we should probably refactor them too. E.g. https://streams.spec.whatwg.org/commit-snapshots/fdeef47522ec54f4c9ea6203c1d3409ebb7f9e8e/#rs-default-controller-close and enqueue. (But not error, for some reason?) Also https://streams.spec.whatwg.org/commit-snapshots/fdeef47522ec54f4c9ea6203c1d3409ebb7f9e8e/#readable-stream-default-controller-should-call-pull . Ctrl+Fing for [[closeRequested]] is how I found these. Maybe "CanCloseOrErrorOrEnqueue" is right after all. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/782#pullrequestreview-59731296
Received on Thursday, 31 August 2017 00:36:24 UTC