Re: [whatwg/fetch] Aborting fetch (#523)

domenic commented on this pull request.



>  
-     <li><p>If <var>stream</var> is <a for=ReadableStream>readable</a>,
-     <a abstract-op>error</a> <var>stream</var> with a
-     <code>TypeError</code>.
+     <li><p>Otherwise, if the bytes transmission for <var>response</var>'s message body is done
+     normally and <var>stream</var> is <a for=ReadableStream>readable</a>, then
+     <a abstract-op>close</a> <var>stream</var> and abort these steps.

Oh, well, "abort these steps" is generally pretty unclear, which is why we're trying to move away from it. So maybe "Abort the in parallel steps", or set a boolean and use that to guard subsequent steps.

Also, it seems you're forgetting to close the connection, if you truly do abort the steps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/523#discussion_r136213680