- From: Tobie Langel <notifications@github.com>
- Date: Fri, 25 Aug 2017 17:34:30 +0000 (UTC)
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 25 August 2017 17:34:55 UTC
tobie commented on this pull request.
A few other nits (sorry for the back-and-forth, I've been mostly OoO today, and looking at this stuff on a phone isn't ideal). Would like to get @bzbarsky to have a look before this is merged. Think he's back next week.
> @@ -8545,6 +8544,58 @@ entails.
</div>
+<h4 id="LegacyNamespace" extended-attribute lt="LegacyNamespace">[LegacyNamespace]</h4>
+
+<p class="advisement">
+ The [{{LegacyArrayClass}}] [=extended attribute=] is an undesirable feature.
s/LegacyArrayClass/LegacyNamespace/
> @@ -10135,7 +10186,7 @@ Note: The HTML Standard defines how a security check is performed. [[!HTML]]
For every non-callback [=interface=] that is [=exposed=] in
a given ECMAScript global environment and that is not declared with
-the [{{NoInterfaceObject}}] [=extended attribute=],
+the [{{NoInterfaceObject}}] or [{{LegacyNamespace}}] [=extended attribute|extended attributes=],
s/[=extended attribute|extended attributes=]/[=extended attributes=]/ (Bikeshed should recognize the plurals.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/425#pullrequestreview-58713792
Received on Friday, 25 August 2017 17:34:55 UTC