Re: [whatwg/fetch] Aborting fetch (#523)

TimothyGu commented on this pull request.

Can't spot anything else from my side. Also looks implementable for [node-fetch](https://github.com/bitinn/node-fetch) which I help maintain.

>     <li>
-    <p>If <var>read</var> is fulfilled with an object whose <code>done</code> property is false
-    and whose <code>value</code> property is a <code>Uint8Array</code> object, then run these steps:
+    <p>Run these steps, but abort if fetch is <a for=fetch>terminated</a>:</p>

It's kind of vague regarding what this 'fetch' is referring to. Elsewhere in this algorithm and document, "the ongoing fetch" is used instead.

This comment applies to elsewhere in the document as well. Grep for "fetch" in https://github.com/whatwg/fetch/pull/523/files?w=1 should help.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/523#pullrequestreview-58028676

Received on Wednesday, 23 August 2017 11:09:20 UTC