- From: Adam Rice <notifications@github.com>
- Date: Wed, 23 Aug 2017 00:31:27 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 23 August 2017 07:31:50 UTC
ricea commented on this pull request.
> + assert_array_equals(events, ['a'], 'the first write should have resolved');
+ return reader.read();
+ }).then(({ value, done }) => {
+ assert_false(done, 'done should still not be true');
+ assert_equals('b', value, 'value should be "b"');
+ return delay(0);
+ }).then(() => {
+ assert_array_equals(events, ['a', 'b', 'closed'], 'the second write and close should be resolved');
+ return reader.read();
+ }).then(({ done }) => {
+ assert_true(done, 'done should be true');
+ });
+}, 'writes should not resolve until backpressure clears');
+
+promise_test(() => {
+ const ts = new TransformStream({}, {}, { highWaterMark: 0 });
`{}` actually has the same effect as `undefined` here. I was trying to be clever and save characters, which was a mistake.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/773#discussion_r134676215
Received on Wednesday, 23 August 2017 07:31:50 UTC