- From: Mike West <notifications@github.com>
- Date: Tue, 22 Aug 2017 12:58:04 +0000 (UTC)
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/582/review/57762904@github.com>
mikewest approved this pull request. LGTM % minor suggestions. Thanks for putting this together! > @@ -813,23 +802,28 @@ the empty string, "<code>worker</code>", or "<code>xslt</code>". Unless stated otherwise it is the empty string. +<p>A <dfn for=export>script-like destination</dfn> is "<code>script</code>", `for=export`? `for=request export`, perhaps? > @@ -813,23 +802,28 @@ the empty string, "<code>worker</code>", or "<code>xslt</code>". Unless stated otherwise it is the empty string. +<p>A <dfn for=export>script-like destination</dfn> is "<code>script</code>", +"<code>serviceworker</code>", "<code>sharedworker</code>", or "<code>worker</code>". Would this be more clear as `A [=request/destination=] is <dfn for="request/destination" export lt="script-like destination">script-like</dfn> if it is one of ..., ..., or ...`? > @@ -813,23 +802,28 @@ the empty string, "<code>worker</code>", or "<code>xslt</code>". Unless stated otherwise it is the empty string. +<p>A <dfn for=export>script-like destination</dfn> is "<code>script</code>", +"<code>serviceworker</code>", "<code>sharedworker</code>", or "<code>worker</code>". Also, what about `XSLT`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/582#pullrequestreview-57762904
Received on Tuesday, 22 August 2017 12:58:27 UTC