- From: Tobie Langel <notifications@github.com>
- Date: Fri, 18 Aug 2017 01:13:30 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/417/review/57135669@github.com>
tobie commented on this pull request. This looks great with a few nits. > @@ -13110,12 +13123,14 @@ The following typographic conventions are used in this document: The following conventions are used in the algorithms in this document: * Algorithms use the [=conventions of the ECMAScript specification=], - including the ! and ? notation for unwrapping completion records. -* Algorithms sometimes treat returning/throwing values and returning completion records + including the ! and ? notation for unwrapping [=Completion Records=]. Would have been nice to link directly to the Completion Record dfn, here, if you're so inclined to file a bug with the TC-39 spec. > interchangeably. That is, an algorithm that uses return/throw terminology may be treated as - returning a completion record, while one that returns a completion record may be treated as - returning a value or throwing an exception. -* Completion records are extended by allowing them to contain values that are not ECMAScript + returning a [=Completion Record=], while one that returns a [=Completion Record=] may be treated as + returning a value or throwing an exception. Similarly, to catch exceptions, defining the + behavior to adopt [=if an exception was thrown=] and checking if the [=Completion Record=]’s + \[[Type]] field is “throw” are equivalent as well. "as well" is a bit redundant, here. > must propagate to the caller, and if not caught there, to its caller, and so on. +Per [[#conventions]], an algorithm specified in this document may intercept thrown exceptions, either by specifying +the exact steps to take <dfn id="dfn-if-an-exception-was-thrown">if an exception was thrown</dfn>, or by explicitly If feels weird to integrate the conditional ("if") within the DFN. I'd be more confortable with: ``` <dfn id="dfn-an-exception-was-thrown">an exception was thrown</dfn> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/417#pullrequestreview-57135669
Received on Friday, 18 August 2017 08:13:52 UTC