Re: [heycam/webidl] [WIP] Link legacy APIs within the advisements (#416)

annevk commented on this pull request.



>  </pre>
 
 <pre class="anchors">
 urlPrefix: https://html.spec.whatwg.org/; spec: HTML
     type: interface
-        text: Audio; url: dom-audio
-        text: Option; url: dom-option
-        text: Image; url: dom-image
+        text: HTMLAudioElement; url: htmlaudioelement
+        text: HTMLOptionElement; url: htmloptionelement
+        text: HTMLImageElement; url: htmlimageelement
+        text: onmouseenter; for: Document; url: handler-onmouseenter
+        text: onmouseleave; for: Document; url: handler-onmouseleave
+        text: onreadystatechange; for: Document; url: handler-onreadystatechange

These should be all be exported if they're not.

>  </pre>
 
 <pre class="anchors">
 urlPrefix: https://html.spec.whatwg.org/; spec: HTML
     type: interface
-        text: Audio; url: dom-audio
-        text: Option; url: dom-option
-        text: Image; url: dom-image
+        text: HTMLAudioElement; url: htmlaudioelement
+        text: HTMLOptionElement; url: htmloptionelement
+        text: HTMLImageElement; url: htmlimageelement
+        text: onmouseenter; for: Document; url: handler-onmouseenter
+        text: onmouseleave; for: Document; url: handler-onmouseleave
+        text: onreadystatechange; for: Document; url: handler-onreadystatechange
+urlPrefix: https://fullscreen.spec.whatwg.org/; spec: FULLSCREEN
+    type: interface;
+        text: fullscreenEnabled; for: Document; url: dom-document-fullscreenenabled
+        text: fullscreen; for: Document; url: dom-document-fullscreen
+        text: fullscreenElement; for: DocumentOrShadowRoot; url: dom-document-fullscreenelement

These too.

> @@ -8644,8 +8664,24 @@ in strict mode to be ignored rather than causing an exception to be thrown.
     <a href="mailto:public-script-coord@w3.org">public-script-coord@w3.org</a>
     mailing list before proceeding.
 
+    <small class="non-normative">

Why no "advisement"?

> @@ -8695,6 +8731,22 @@ See the <a href="#es-attributes">Attributes</a> section for how
 
 <h4 id="LenientThis" extended-attribute lt="LenientThis">[LenientThis]</h4>
 
+<div class="advisement">
+    Specifications should not use [{{LenientThis}}]
+    unless required for compatibility reasons.  Specification authors who
+    wish to use this feature are strongly advised to discuss this on the
+    <a href="mailto:public-script-coord@w3.org">public-script-coord@w3.org</a>
+    mailing list before proceeding.

Maybe open an issue on GitHub instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/416#pullrequestreview-56903378