Re: [heycam/webidl] Use <emu-val> only for constant values (#405)

tobie approved this pull request.

This looks great. We can either merge it as is and come back to fix the link later, or keep it open until the link is added to the ES spec.

> @@ -1144,8 +1145,8 @@ defined on the same interface.
 The identifier also must not
 be “length”, “name” or “prototype”.
 
-Note: These three names are the names of properties that exist on all
-[=function objects=].
+Note: These three names are the names of properties that may exist on

Nice catch.

> @@ -10983,7 +10984,7 @@ The value of the [=@@iterator=] [=function object=]’s “name” property
 is the String value “entries”
 if the interface has a [=pair iterator=] or a [=maplike declaration=]
 and the String “values”
-if the interface has a [=setlike declaration=].
+if the interface has a [=setlike declaration=] or defines an [=indexed property getter=].

Seems like this is an orthogonal issue that could be split up in to its own PR.

>      value that represents the same sequence of [=code units=] as
     the [=enumeration value=].
 </p>
 
 
 <h4 id="es-callback-function">Callback function types</h4>
 
-IDL [=callback function types=] are represented by ECMAScript <emu-val>Function</emu-val>
+IDL [=callback function types=] are represented by ECMAScript function

Might want to link this one too.

>  if the interface has a [=pair iterator=] or a [=maplike declaration=]
-and the <emu-val>String</emu-val> “values”
-if the interface has a [=setlike declaration=].
+and the String “values”
+if the interface has a [=setlike declaration=] or defines an [=indexed property getter=].

This seem like an orthogonal issue that would be better left in a separate PR, no?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/405#pullrequestreview-56320382