Re: [heycam/webidl] Use <emu-val> only for constant values (#405)

tobie commented on this pull request.

Hey, thanks for making this.

Noticed a few nits, but overall this is great.

On the fence about whether we should also link Number, Symbol, Object, String, etc.

Also, as @annevk mentioned on irc, please do add your name to the credits.

> @@ -139,7 +145,7 @@ urlPrefix: https://tc39.github.io/ecma262/; spec: ECMA-262
         text: sections 9.1; url: sec-ordinary-object-internal-methods-and-internal-slots
         text: 9.3.1; url: sec-built-in-function-objects-call-thisargument-argumentslist
         text: ECMA-262 section 9.3; url: sec-built-in-function-objects
-        text: function object; url: sec-built-in-function-objects

I *think* we were trying to make a distinction between functions and built-in functions here which this change looses.

> @@ -6668,7 +6674,7 @@ In effect, where <var ignore>x</var> is a <emu-val>Number</emu-val> value,
 
     1.  Let |x| be [=?=] [=ToNumber=](|V|).
     1.  If |x| is <emu-val>NaN</emu-val>, +∞, or −∞,
-        then [=ECMAScript/throw=] a <emu-val>TypeError</emu-val>.
+        then [=ECMAScript/throw=] a {{TypeError}}.

That (and others) links to the WebIDL type, no? Think you want a similar setup here as for ES/SyntaxError.

> @@ -6181,7 +6187,7 @@ Unless otherwise specified, the \[[Extensible]] internal property
 of objects defined in this section has the value <emu-val>true</emu-val>.
 
 Unless otherwise specified, the \[[Prototype]] internal property
-of objects defined in this section is the <emu-val>Object</emu-val> prototype object.
+of objects defined in this section is the Object prototype object.

Shouldn't we go ahead and link %ObjectPrototype% here instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/405#pullrequestreview-56066036