- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 10 Aug 2017 01:01:15 -0700
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 10 August 2017 08:01:37 UTC
annevk approved this pull request. LGTM with a couple of nits. > @@ -408,6 +408,12 @@ the row where the value in the cell in the first column is <a>context object</a> <p>The <a>synchronous flag</a>, <a>upload complete flag</a>, and <a>upload listener flag</a> are initially unset. +<p class=note id=event-listeners-and-preflight>Registering one or more +event listeners on an {{XMLHttpRequestUpload}} object will trigger user +agents to perform a <a>CORS-preflight request</a>. (That is because +registering an event listener causes the <a>upload listener flag</a> to be +set, which in turn causes the <a>use-CORS-preflight flag</a> to be set.) Could you use `class="note no-backref"` please? And maybe s/trigger user agents to perform/result in/. Also, 100 columns please. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/148#pullrequestreview-55459939
Received on Thursday, 10 August 2017 08:01:37 UTC