Re: [whatwg/fetch] Editorial: Making headers their own property (#575)

annevk approved this pull request.

Couple nits, generally looks good. Thanks!

> @@ -4725,9 +4728,7 @@ omitted from <a enum><code>RequestMode</code></a> as it cannot be used nor obser
 <p>A {{Request}} object has an associated
 <dfn id=concept-request-request for=Request export>request</dfn> (a <a for=/>request</a>).
 
-<p>A {{Request}} object also has an associated {{Headers}} object which
-is itself associated with <a for=Request>request</a>'s
-<a for=request>header list</a>.
+<p>A {{Request}} object also has associated <dfn for=Request>headers</dfn> (a {{Headers}} object).

an associated?

>  
- <li><p>Let <var>headers</var> be a copy of <var>r</var>'s {{Headers}} object and its
+ <li><p>Set <var>r</var>'s <a for=Request>headers</a> to <var>headersObject</var>.

Maybe merge this with the previous step? Set r's headers to a new Headers object, ... And then we don't need to use _headersObject_.

> @@ -5165,9 +5178,7 @@ enum ResponseType { "basic", "cors", "default", "error", "opaque", "opaqueredire
 <dfn id=concept-response-response for=Response export>response</dfn> (a
 <a for=/>response</a>).
 
-<p>A {{Response}} object also has an associated {{Headers}} object which
-is itself associated with <a for=Response>response</a>'s
-<a for=response>header list</a>.
+<p>A {{Response}} object also has associated <dfn for=Response>headers</dfn> (a {{Headers}} object).

an associated?

> @@ -4725,9 +4728,7 @@ omitted from <a enum><code>RequestMode</code></a> as it cannot be used nor obser
 <p>A {{Request}} object has an associated
 <dfn id=concept-request-request for=Request export>request</dfn> (a <a for=/>request</a>).
 
-<p>A {{Request}} object also has an associated {{Headers}} object which
-is itself associated with <a for=Request>request</a>'s
-<a for=request>header list</a>.
+<p>A {{Request}} object also has associated <dfn for=Request>headers</dfn> (a {{Headers}} object).

Also, should we say "null or a Headers object" and initially null since it's not always there? (Same for Response.)

> @@ -5187,9 +5198,13 @@ constructor, when invoked, must run these steps:
  <li><p>If <var>init</var>'s <code>statusText</code> member does not match the
  <a spec=http>reason-phrase</a> token production, then <a>throw</a> a <code>TypeError</code>.
 
- <li><p>Let <var>r</var> be a new {{Response}} object, associated with a new
- <a for=/>response</a> and a new associated {{Headers}} object whose
- <a for=Headers>guard</a> is "<code>response</code>".
+ <li><p>Let <var>r</var> be a new {{Response}} object associated with a new <a for=/>response</a>.
+
+ <li><p>Let <var>headersObject</var> be a new {{Headers}} object, whose
+ <a for=Headers>header list</a> is <var>r</var>'s <a for=Response>response</a>'s
+ <a for=response>header list</a>, and <a for=Headers>guard</a> is "<code>response</code>".
+
+ <li><p>Set <var>r</var>'s <a for=Response>headers</a> to <var>headersObject</var>.

Inline the previous step here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/575#pullrequestreview-55455150