Re: [whatwg/dom] DOMTokenList shouldn't add empty attributes (#488)

annevk commented on this pull request.

Coupled with rewrapping using 100columns and tests this seems okay to me.

> @@ -9509,10 +9509,17 @@ associated <a>attribute</a>'s <a for=Attr>local name</a>.
  <li><p>Return false.
 </ol>
 
-<p>A {{DOMTokenList}} object's <dfn id=concept-dtl-update for="DOMTokenList">update steps</dfn> are
-to <a>set an attribute value</a> for the associated <a for="/">element</a> using associated
-<a>attribute</a>'s <a for=Attr>local name</a> and the result of running the
-<a>ordered set serializer</a> for <a>token set</a>.
+<p>A {{DOMTokenList}} object's <dfn id=concept-dtl-update for="DOMTokenList">update steps</dfn> are:
+
+<ol>
+ <li><p>If the associated <a for="/">element</a> does not have an associated
+ <a>attribute</a>, and <a>token set</a> is empty, do nothing.

s/, and/ and/
s/do nothing/then return/

> @@ -9509,10 +9509,17 @@ associated <a>attribute</a>'s <a for=Attr>local name</a>.
  <li><p>Return false.
 </ol>
 
-<p>A {{DOMTokenList}} object's <dfn id=concept-dtl-update for="DOMTokenList">update steps</dfn> are
-to <a>set an attribute value</a> for the associated <a for="/">element</a> using associated
-<a>attribute</a>'s <a for=Attr>local name</a> and the result of running the
-<a>ordered set serializer</a> for <a>token set</a>.
+<p>A {{DOMTokenList}} object's <dfn id=concept-dtl-update for="DOMTokenList">update steps</dfn> are:
+
+<ol>
+ <li><p>If the associated <a for="/">element</a> does not have an associated
+ <a>attribute</a>, and <a>token set</a> is empty, do nothing.
+
+ <li><p>Otherwise, <a>set an attribute value</a> for the associated
+ <a for="/">element</a> using associated <a>attribute</a>'s
+ <a for=Attr>local name</a> and the result of running the
+ <a>ordered set serializer</a> for <a>token set</a>.

s/Otherwise, s/S/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/488#pullrequestreview-54851449