Re: [w3ctag/design-reviews] Request for TAG review of Input Events level 1 (#160)

Thanks a lot for the review request. We are excited to see this work happening - writing editors for the web has always been a painful task, and it's great to see this improving. @travisleithead, @slightlyoff, and I touched on this during our Tokyo F2F.

Here are some first-pass comments:

Just out of curiosity, there is a specific unusual operation that touches transposing the last two characters which were entered - is this a common OS level primitive operation? It would be interesting to know the use case and rationale behind this is. It feels a bit out of place compared to the other generic operations.

This is mostly editorial, but 5.1.2 could be better as a table, the current presentation method feels like it would be defining a sequence algorithm. Grouping operations based on category in the table might make sense in this case.

There are mentions about soft lines and hard lines with no definition, which implies domain knowledge. This isn't always the case, so it would be nice to have it in definition, or link to a definition if it is defined elsewhere.

While we understand that this comes from a underlying infrastructural issue (HTML) - colors are just mentioned as "hex digit value", which could be a bit more specific. I believe the concept you are looking for is *simple color* (defined in HTML), but this has the downside of not having alpha channel support.

https://html.spec.whatwg.org/multipage/infrastructure.html#colours
http://w3c.github.io/html/infrastructure.html#colors

We discussed briefly within the TAG whether or not CSS typed OM would have something that you could use for some of the style related properties in , this would be worth checking on your side as well.

Adding a link to the explainer document http://w3c.github.io/editing/ from the spec would be great.

Double checking if there are any potential issues with regards to re-entrance in implementations is probably something that we'll need a bit more time on.

@slightlyoff had concerns about beforeinput not firing on input elements. Further comments should come from his direction.

Additionally, we looked at both level 2 and level 1, and the different pieces in level 2 seemed to be fine for us, so unless there are specific parts that you would like us to look into specific to level 2, we could close w3ctag/design-reviews#173 and fold it back into this issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/160#issuecomment-298142321