Re: [whatwg/url] Editorial: use Infra in a/x-www-form-urlencoded (#300)

annevk commented on this pull request.

You're right. We could move ahead with this and make that change later. I have a couple nits though if we want to move ahead here.

>  
- <li><p>For each name-value tuple in <var>tuples</var>, append a name-value tuple to
- <var>output</var> where the new name and value appended to <var>output</var> are the result of
- running <a>UTF-8 decode without BOM</a> on the <a lt="percent decode">percent decoding</a> of the
- name and value from <var>tuples</var>, respectively, using <var>encoding</var>.
+   <li><p><a for=list>Append</a> <var>nameString</var>/<var>valueString</var> to <var>output</var>.

Could you use the tuple syntax instead? See https://github.com/whatwg/infra/issues/127.

> @@ -2378,11 +2377,11 @@ takes a byte sequence <var>input</var>, and then runs these steps:
 
 <ol>
  <li><p>Let <var>sequences</var> be the result of splitting <var>input</var> on
- `<code>&amp;</code>`.
- <!-- XXX define splitting? DOM does not do it -->
+ 0x26 (&amp;).
+ <!-- XXX define strictly splitting for byte sequences in Infra -->

Could you add "or decode earlier" to this comment, since we haven't decided on which is better.

> @@ -129,10 +129,9 @@ contains bytes that are not <a>ASCII bytes</a> might be insecure and is not reco
   <p>For each byte <var>byte</var> in <var>input</var>:
 
   <ol>
-   <li><p>If <var>byte</var> is not `<code>%</code>`, append
-   <var>byte</var> to <var>output</var>.
+   <li><p>If <var>byte</var> is not 0x25 (%), append <var>byte</var> to <var>output</var>.

then append*

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/300#pullrequestreview-35292019