Re: [whatwg/url] Annevk/ipv6 more (#286)

domenic approved this pull request.

Changes work fine in whatwg-url, although it seems like this is mostly just renaming variables, so I am not sure of the value.

I agree with @rmisev's critiques.

> @@ -521,22 +523,14 @@ these steps:
 then runs these steps:
 
 <ol>
- <li><p>Let <var>address</var> be a new <a>IPv6 address</a> with its
- <a lt='IPv6 piece'>16-bit pieces</a> initialized to 0.
+ <li><p>Let <var>address</var> be a new <a>IPv6 address</a> whose <a>IPv6 pieces</a> are 0.

I think this would be clearer as "whose IPv6 pieces are all 0"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/286#pullrequestreview-34393196