Re: [w3c/manifest] Feat(events): add BeforeInstallPromptEvent (#520)

> cannot use await now though (not async method...)

The inner function is async, and that's where I use await. I tested it, and it works. (The outer function does not need to be async since it just immediately does things including setting up a click handler.)

> I think that squashing is nicer... But you could do one commit for Marcos work and one for your modifications

Squashed into two commits.

Also, how about my HTMLTidy question?

> I see a bunch of people using htmltidy on their specs. I tried to use this but it complained about the special respec elements and refused to do anything. Is there a trick for getting it to work on respec documents?

Lastly, please wait for me to get some more people at Google to look at this before merging. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/520#issuecomment-296520210

Received on Monday, 24 April 2017 04:05:51 UTC