- From: Rimas Misevičius <notifications@github.com>
- Date: Wed, 12 Apr 2017 11:01:52 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 12 April 2017 18:02:26 UTC
Changes:
1. Moves _ipv4Piece_ verification step right after the _ipv4Piece_ calculation. Because if the "_ipv4Piece_ > 255" verification returns failure, then no need to increase _pointer_.
2. Moves the last (8.) step to the outside of 6.5.5 loop. This lets drop `c is the EOF` check in this moved step, because loop stops on `EOF`. This obviously gives a better performance.
These changes are based on https://github.com/nodejs/node/pull/12315#discussion_r110858300 and https://github.com/nodejs/node/pull/12315#discussion_r110879264
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/url/pull/292
-- Commit Summary --
* IPv4 in IPv6 cleanup
-- File Changes --
M url.bs (9)
-- Patch Links --
https://github.com/whatwg/url/pull/292.patch
https://github.com/whatwg/url/pull/292.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/292
Received on Wednesday, 12 April 2017 18:02:26 UTC