Re: [whatwg/streams] Unified error handling for WritableStream (#721)

tyoshino commented on this pull request.

Finished reviewing the reference impl.

looks good.

>  }
 
 function WritableStreamUpdateBackpressure(stream, backpressure) {
-  assert(stream._state === 'writable');
+  assert(stream._state === 'writable' || stream._state === 'erroring');

When does this get called with state set to erroring?

>  
-  assert(state === 'writable');
+  assert(state === 'writable' || state === 'erroring');

Hmm, what was the rationale to have close() succeed while write() fails when the state is erroring?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/721#pullrequestreview-32346965