- From: Victor Costan <notifications@github.com>
- Date: Tue, 04 Apr 2017 15:02:04 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 4 April 2017 22:03:02 UTC
pwnall approved this pull request.
LGTM with nits.
> @@ -2628,26 +2628,26 @@ instance on which it was called.
The <dfn method for=IDBDatabase>transaction(|storeNames|,
|mode|)</dfn> method, when invoked, must run these steps:
-1. If |mode| parameter is not {{"readonly"}} or {{"readwrite"}},
- [=throw=] a [=TypeError=].
-
-2. If this method is called on {{IDBDatabase}} object for which an
+1. If this method is called on {{IDBDatabase}} object for which an
on an {{IDBDatabase}}?
FWIW, I liked instance a bit better than object. Also, I think you can get away without either.
> store=] in the [=connected=] [=database=], [=throw=] a
"{{NotFoundError}}" {{DOMException}}.
-6. If |scope| is empty, [=throw=] an "{{InvalidAccessError}}" {{DOMException}}.
+5. If |scope| is empty, [=throw=] an "{{InvalidAccessError}}" {{DOMException}}.
+
+6. If |mode| parameter is not {{"readonly"}} or {{"readwrite"}},
the |mode| parameter, or just |mode|?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/188#pullrequestreview-30913617
Received on Tuesday, 4 April 2017 22:03:02 UTC