Re: [whatwg/fullscreen] Update fullscreen spec to be Shadow DOM compliant (#54)

TakayoshiKochi commented on this pull request.

Thanks for all your reviews!
Much appreciated.


> -<p class=note>Use
-<a attribute for=Document lt=fullscreenElement><code>document.fullscreenElement</code></a> instead.
+<p class=note>Use {{DocumentOrShadowRoot/fullscreenElement}} instead.
+
+<p>The
+<dfn attribute for=DocumentOrShadowRoot id=dom-document-fullscreenelement><code>fullscreenElement</code></dfn>
+attribute's getter must run these steps:
+
+<ol>
+ <li><p>If the <a>context object</a> is a <a for=/>shadow root</a> and its
+ <a for=DocumentFragment>host</a> is not <a>connected</a>, then return null.</li>
+
+ <li><p>Let <var>candidate</var> be the result of <a>retargeting</a> <a>fullscreen element</a>
+ against the <a>context object</a>.
+
+ <li><p>If <var>candidate</var> and the <a>context object</a> are in the same tree, return

Done.

> @@ -502,12 +520,19 @@ properties apply to this pseudo-element either.
 
 <h3 id=:fullscreen-pseudo-class><code>:fullscreen</code> pseudo-class</h3>
 
-<p>The <dfn id=css-pc-fullscreen><code>:fullscreen</code></dfn> pseudo-class must match any
-<a>element</a> that has its <a>fullscreen flag</a> set.
+<p>The <dfn id=css-pc-fullscreen><code>:fullscreen</code></dfn> pseudo-class must match an
+<a>element</a> <var>element</var> if any of the following conditions is true:

Done.

>  
-<p class="note no-backref">This makes it different from the {{Document/fullscreenElement}} API,
-which returns a <a>document</a>'s <a>fullscreen element</a>.
+<ul>
+ <li><p><var>element</var>'s <a>fullscreen flag</a> is set.
+
+ <li><p><var>element</var> is a <a>shadow host</a> and the result of <a>retargeting</a> its
+ <a>node document</a>'s <a>fullscreen element</a> against <var>element</var> is equal to
+ <var>element</var>.

Done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/54#pullrequestreview-2335939