Re: [whatwg/fullscreen] Update fullscreen spec to be Shadow DOM compliant (#54)

TakayoshiKochi commented on this pull request.

Updated the patch.
This fixes nits and the `:fullscreen` definition.

Also fixes bikeshed link error for `<a>shadow root</a>`.

Could you take another look?

> -<p class=note>Use
-<a attribute for=Document lt=fullscreenElement><code>document.fullscreenElement</code></a> instead.
+<p class=note>Use {{DocumentOrShadowRoot/fullscreenElement}} instead.
+
+<p>The
+<dfn attribute for=DocumentOrShadowRoot id=dom-document-fullscreenelement><code>fullscreenElement</code></dfn>
+attribute's getter must run these steps:
+
+<ol>
+  <li><p>If the <a>context object</a> is a <a>shadow root</a> and its <a for=DocumentFragment>host</a>
+  is not <a>connected</a>, then return null.</li>
+  <li><p>Let <var>candidate</var> be the result of <a>retargeting</a> <a>fullscreen element</a>
+  against the <a>context object</a>.
+  <li><p>If <var>candidate</var> and the <a>context object</a> are in the same tree,
+  return <var>candidate</var>.
+  <li><p>Return null.

Done.

>  
+<p class="note no-backref">This makes it different from the fullscreenElement API, which returns

Is `s/the fullscreenElement API/{{DocumentOrShadowRoot/fullscreenElement}}/` the expected fix?
Looking around the spec, `{{...}}` is obviously an API, so 'the' and 'API' seem redundant.
Also removed one `returns`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/54#pullrequestreview-2271125