- From: Takayoshi Kochi <notifications@github.com>
- Date: Fri, 16 Sep 2016 02:43:07 -0700
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Message-ID: <whatwg/fullscreen/pull/54/review/322409@github.com>
TakayoshiKochi commented on this pull request.
> @@ -78,25 +78,29 @@ unset.
<p>All <{iframe}> <a>elements</a> have an associated <dfn>iframe fullscreen flag</dfn>. Unless
stated otherwise it is unset.
-<p>All <a>documents</a> have an associated <dfn>fullscreen element</dfn>. The
-<a>fullscreen element</a> is the topmost <a>element</a> in the <a>document</a>'s <a>top layer</a>
-whose <a>fullscreen flag</a> is set, if any, and null otherwise.
-
-<p>To <dfn>fullscreen an <var>element</var></dfn> within a <var>document</var>, set the
-<var>element</var>'s <a>fullscreen flag</a> and <a>add</a> it to <var>document</var>'s
-<a>top layer</a>.
-
-<p>To <dfn>unfullscreen an <var>element</var></dfn> within a <var>document</var>, unset the
-<var>element</var>'s <a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and
-<a>remove</a> it from <var>document</var>'s <a>top layer</a>.
-
-<p>To <dfn>unfullscreen a <var>document</var></dfn>,
+<p>All <a>document trees</a> have an associated <dfn>fullscreen element</dfn>. The
FYI "document tree" is defined at [DOM spec](https://dom.spec.whatwg.org/#concept-document-tree).
I seem to misunderstand 'document tree', actually it is restricted to the node tree whose root is document, and excludes any shadow trees.
I thought it was a replacement for 'shadow-including document'.
I'm rewriting the patch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/54
Received on Friday, 16 September 2016 09:43:43 UTC