Re: [whatwg/streams] assert invariants in InvokeOrNoop and friends (#584)

isonmad commented on this pull request.



> @@ -62,6 +62,10 @@ exports.IsFiniteNonNegativeNumber = v => {
 };
 
 exports.InvokeOrNoop = (O, P, args) => {
+  assert(exports.typeIsObject(O) === true);
+  assert(typeof P === 'string');
+  assert(Array.isArray(args));

Given that the impetus for writing this PR was an accidental bug where `args` was not passed, when it was intended to be passed, I think it hurts, yeah.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/584