Re: [whatwg/streams] assert invariants in InvokeOrNoop and friends (#584)

isonmad commented on this pull request.



> @@ -62,6 +62,10 @@ exports.IsFiniteNonNegativeNumber = v => {
 };
 
 exports.InvokeOrNoop = (O, P, args) => {
+  assert(exports.typeIsObject(O) === true);
+  assert(typeof P === 'string');

Yeah, should probably do that, but then again, all callers are guaranteed to pass a constant string, so do we need to allow Symbols if they're never used?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/584