Re: [whatwg/streams] eslint fixes and standardize exports style (#579)

isonmad commented on this pull request.



> @@ -21,11 +21,11 @@ wptRunner(toUpstreamTestsPath, { rootURL: 'streams/', setup })
   })
   .then(failures => {
     totalFailures += failures;
-    process.exit(totalFailures);
+    process.exitCode = totalFailures;

Wait, why not? Why would the process need to exit immediately, when it's about to exit on its own naturally regardless as this is the last thing that gets run and nothing else is keeping process alive? This seems cleaner.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/579