Re: [whatwg/streams] eslint fixes and standardize exports style (#579)

domenic requested changes on this pull request.



> @@ -19,7 +19,7 @@
     // Possible errors
     "comma-dangle": ["error", "never"],
     "no-cond-assign": ["error", "except-parens"],
-    "no-console": "error",
+    "no-console": "off",

Don't turn this off globally. Turn it off inside the file that uses console, using `/*eslint-disable no-console */`

> @@ -21,11 +21,11 @@ wptRunner(toUpstreamTestsPath, { rootURL: 'streams/', setup })
   })
   .then(failures => {
     totalFailures += failures;
-    process.exit(totalFailures);
+    process.exitCode = totalFailures;

Don't change this just to get around the restriction. Use `/*eslint-disable*/`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/579#pullrequestreview-6456907