- From: Matt Giuca <notifications@github.com>
- Date: Fri, 28 Oct 2016 01:21:07 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Message-ID: <w3c/manifest/issues/417/256863752@github.com>
Yeah I actually agree about that. I think the only argument for it is that you're *supposed* to use preventDefault-prompt as a pair to delay showing the banner. If you call prompt without preventDefault, it's essentially a no-op and I think we just put that error there because it's "nonsensical". But: 1. Just because something is a no-op doesn't mean it should throw an error, and 2. You can get around it anyway, as you pointed out, and 3. If we add a long-wait promise to tell you what the outcome is, there is actually utility in calling prompt() without preventDefault, because you will be told what the user's choice is. (i.e., it means prompt() subsumes userChoice, and then you literally never need userChoice). This allows us to actually say userChoice is deprecated (though as discussed yesterday, killing it is hard since apparently it has a lot of usage). So I'd say take out that error. It also doesn't break any sites if we remove it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/issues/417#issuecomment-256863752
Received on Friday, 28 October 2016 08:22:24 UTC