Re: [whatwg/streams] Tests for Sink methods returning thenable (#570)

domenic approved this pull request.

LGTM with nit; thanks for testing.

> @@ -203,3 +203,19 @@ test(() => {
     assert_array_equals(ws.events, ['close']);
   });
 }, 'WritableStream should call underlying sink\'s close if no abort is supplied');
+
+promise_test(() => {
+  let thenCalled = false;
+  const ws = new WritableStream({
+    abort() {
+      return {
+        then(resolve) {

Nit: the proper argument names are `(onFulfilled, onRejected)` not `(resolve, reject)`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/570#pullrequestreview-6159847