Re: [heycam/webidl] Merge algo and dfn for "detaching an ArrayBuffer" (#210)

domenic approved this pull request.

LGTM, good catch that this was defined in two places.

> @@ -7992,9 +7989,9 @@ a reference to the same object that the IDL value represents.
         starting at byte offset |offset|.
 </div>
 
-<div algorithm="detach an arraybuffer">
+<div algorithm>

Can I ask what's the difference between `algorithm="something"` and just `algorithm`?

>  
-    To [=detach=] an {{ArrayBuffer}}, these steps must be followed:
+    To <dfn id="dfn-detach" for="ArrayBuffer" export>detach</dfn> an {{ArrayBuffer}}, these steps must be followed:
 
     1.  Let |O| be the ECMAScript object that is the {{ArrayBuffer}}.
     1.  [=DetachArrayBuffer=](|O|).

While here, maybe change this to `Perform [=!=] [=DetachArrayBuffer=](|O|)` as part of the modernization process

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/210#pullrequestreview-6072464

Received on Thursday, 27 October 2016 14:42:22 UTC