Re: [w3c/manifest] WIP: beforeinstallprompt (#506)

kenchris commented on this pull request.



> +    if (!event.defaultPrevented) {
+      await requestInstallPrompt(event, element);
+    }
+  }
+
+  function trackReadyState() {
+    return new Promise((resolve) => {
+      document.addEventListener("readystatechange", () => {
+        if (document.readyState === "complete") {
+          resolve();
+        }
+      });
+    });
+  }
+
+  async function showInstallPrompt(button) {

the functon calling this called the argument element, why not just call it button there as well

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/506#pullrequestreview-5429228