- From: Takeshi Yoshino <notifications@github.com>
- Date: Mon, 24 Oct 2016 03:39:16 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Monday, 24 October 2016 10:39:43 UTC
tyoshino commented on this pull request.
> +
+ const writer = ws.getWriter();
+ writer.write('Hello');
+
+ return promise_rejects(t, error1, writer.closed, 'writer.closed must reject with the write error')
+ .then(() => {
+ writer.releaseLock();
+
+ return promise_rejects(t, error1, rs.pipeTo(ws), 'pipeTo must reject with the write error')
+ .then(() => {
+ assert_array_equals(rs.eventsWithoutPulls, ['cancel', error1]);
+ assert_array_equals(ws.events, ['write', 'Hello']);
+ });
+ });
+
+}, 'Errors must be propagated backward: becomes errored before piping due to write; preventCancel omitted; ' +
Got it. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/512
Received on Monday, 24 October 2016 10:39:43 UTC