Re: [whatwg/fetch] Add request's reserved client (#383)

annevk commented on this pull request.



> +<span data-anolis-spec=html>environment settings object</span>). Unless stated otherwise it is null.
+
+<p class="note no-backref">This is only used by <span>navigation requests</span> and worker requests
+(except service worker requests). It references an <span data-anolis-spec=html>environment</span>
+for a <span>navigation request</span> and an <span data-anolis-spec=html>environment settings
+object</span> for a worker request.
+
+<p>A <span title=concept-request>request</span> has an associated
+<dfn title=concept-request-target-client-id data-export data-dfn-for=request>target client id</dfn>
+(a string). Unless stated otherwise it is the empty string.
+
+<p class="note no-backref">This is only used by <span>navigation requests</span>. It has the
+<span data-anolis-spec=html>id</span> of the <span data-anolis-spec=html>target browsing
+context</span>'s <span data-anolis-spec=html>active document</span>'s
+<span data-anolis-spec=html>environment settings object</span> captured before entering the
+<span title=concept-fetch>fetch</span> algorithm.

I was about to merge, but I don't understand this. The target client ID isn't that a reserved ID of sorts?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/383#pullrequestreview-5398205

Received on Monday, 24 October 2016 07:42:17 UTC