Re: [heycam/webidl] Use [[isExtensible]] over prose. (#197)

domenic requested changes on this pull request.



> @@ -12521,6 +12518,19 @@ values passed to \[[Call]]:
 </ol>
 
 
+<h4 id="preventextensions">Platform object \[[PreventExtensions]] method</h4>
+
+The internal \[[PreventExtensions]] method of every [=platform object=] |O|

I don't think that's the way to go. It's better to define a single type of object, a "platform object", which always has a given set of internal methods, instead of swapping out different types of objects. That's what we do for all the other internal methods: branch on whether they support named/indexed properties.

If you're concerned about forward-compatibility, you can fall back to [OrdinaryPreventExtensions](https://tc39.github.io/ecma262/#sec-ordinarypreventextensions) for the other cases.

> @@ -12521,6 +12518,19 @@ values passed to \[[Call]]:
 </ol>
 
 
+<h4 id="preventextensions">Platform object \[[PreventExtensions]] method</h4>
+
+The internal \[[PreventExtensions]] method of every [=platform object=] |O|
+that implements an [=interface=] which
+[=support indexed properties|supports indexed=] or
+[=support named properties|named properties=]
+must behave as follows when called:
+
+<ol class="algorithm">

Oh, dang, I'm not in favor of that personally. But at least it'd be good to be consistent between this and named properties object in the same PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/197#pullrequestreview-5352706