Re: [whatwg/streams] Rigorously specify and test pipeTo (#512)

> Can't that be done without involving the whole pipeLoop? It doesn't really need all the shutdown infrastructure does it.

It could. I find the spec and reference implementation cleaner this way.

> As we can see the source clearly based on which value we passed to the prevent.* flag, I don't strongly object to this now, but some note needed to explain this behavior.

Added some bullet points

> please add some tests where two or more of prevent.* flags are set to true.

Hmm. Given that only one flag can be used in any given pipeTo, I'm not sure how valuable this would be. Could you give an example of what you'd be hoping to test?

Although, I guess I just realized we do not have any tests for multiple close/error conditions being true at once :(. So e.g. piping a closed readable stream to an errored writable stream and so on. The spec isn't even super clear about what takes precedence there. I guess that's another reasonably large chunk of work to do. I'll try to do it Monday.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/512#issuecomment-255479603