- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 21 Oct 2016 12:54:48 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Message-ID: <w3c/IndexedDB/pull/101/review/5309301@github.com>
domenic approved this pull request.
>
3. If |key| is failure, abort the overall algorithm and return
failure.
- 4. Append the result of the first sub-step to end of |result|.
+ 4. Let |p| be ! [=ToString=](|i|).
+
+ 5. Let |status| be [=CreateDataProperty=](|result|, |p|, |key|).
+
+ 6. Assert: |status| is true.
Some mixed tabs and spaces here it seems
> <dd>Let |value| be a Number equal to the number of elements in |value|.</dd>
<dt>If |value| is an [=Array=] and |identifier| is "<code>length</code>"</dt>
- <dd>Let |value| be [=!=] ToLength([=!=] Get(|value|, "<code>length</code>")).</dd>
+
+ <dd>Let |value| be [=!=] [=ToLength=]([=!=] Get(|value|, "<code>length</code>")).</dd>
Link Get()?
> @@ -23,46 +23,56 @@ Test Suite: https://github.com/w3c/web-platform-tests/tree/master/IndexedDB
spec: html; urlPrefix: https://html.spec.whatwg.org/multipage/
I wonder how many of these are still necessary.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/101#pullrequestreview-5309301
Received on Friday, 21 October 2016 19:55:21 UTC