- From: Matt Giuca <notifications@github.com>
- Date: Thu, 20 Oct 2016 00:05:29 -0700
- To: w3c/manifest <manifest@noreply.github.com>
Received on Thursday, 20 October 2016 07:06:05 UTC
I'm not sure we need a state machine: the "prompting" and "done" states aren't both needed... they are indistinguishable except for the error message so we can merge them into one and are back with a Boolean again. (Actually, it'd be nice to work defaultPrevented into a multi-state machine, but since it's a Boolean in the underlying platform, let's not.) So prompt becomes: ``` if (didPrompt) { error "prompt has already been shown" return; } if (defaultPrevented) { error "must call preventDefault first" return; } show prompt didPrompt = true; ``` And if the prompt is automatically shown, it also sets didPrompt to true. Does it need to be more complicated than that? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/issues/417#issuecomment-255025905
Received on Thursday, 20 October 2016 07:06:05 UTC