Re: [heycam/webidl] Reword the distinguishability algorithm. (#194)

domenic commented on this pull request.



> +
+            interface Bar {
+                attribute DOMString attr2;
+            };
+
+            dictionary Baz {
+                DOMString field1;
+            };
+        </pre>
+
+        <code>Foo</code> is distinguishable from <code>Bar</code>
+        because the pair satisfies note (a),
+        but it is not distinguishable from <code>Baz</code>
+        because that pair does not satisfy note (b).
+
+        [=Promise types=] do not appear in the above table, and as a consequence are

This should probably not be in the example, but stay in a separate note.

>  
-1.  The two types (taking their [=inner types=]
+<ol class="algorithm">
+1.  If both types are either a [=union type=] or nullable union type,
+    return <i>true</i> if each member type of the one

I don't think we `<i>` booleans in this spec...

> @@ -3491,15 +3512,40 @@ and at least one of the following three conditions is true:
             and it is not the case that both are [=callback interfaces=].
         1.  The interface type is not a [=callback interface=].
     </ol>
-1.  One type is a [=union type=] or nullable union type,
-    the other is neither a union type nor a nullable union type, and each
-    [=member type=] of the first is distinguishable
-    with the second.
-1.  Both types are either a union type or nullable union type, and each member type of the one
-    is distinguishable with each member type of the other.
-
-Note: [=Promise types=] do not appear in the above table, and as a consequence
-are not distinguishable with any other type.
+
+    <div class="example" id="example-distinguishability">

IMO this should be three `<div class="example">`s in sequence, but I am not sure what the rest of the spec does, so meh.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/194#pullrequestreview-4766994