Re: [whatwg/streams] Rigorously specify and test pipeTo (#512)

tyoshino commented on this pull request.



>          }
-      );
-      _state = 'waitingLastWriteOnReadableClosed';
-    }
-
-    function doPipe() {
-      // console.log('pipeTo(): doPipe()');
+        shuttingDown = true;
+
+        waitForCurrentWrite().then(() => {
+          action().then(
+            () => performShutdown(originalIsError, originalError),
+            newError => performShutdown(true, newError)

It's nice to propagate all the errors to someone, but it means that when preventCancel (or preventAbort) is not in use, the original cause of error is lost. It sounds bad.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/512