Re: [whatwg/streams] Rigorously specify and test pipeTo (#512)

isonmad commented on this pull request.



>  
     preventClose = Boolean(preventClose);
     preventAbort = Boolean(preventAbort);
     preventCancel = Boolean(preventCancel);
 
-    const source = this;
+    const reader = AcquireReadableStreamDefaultReader(this);
+    const writer = AcquireWritableStreamDefaultWriter(dest);

Why do the brand checks above return a rejected promise (instead of throwing synchronously), when `AcquireReadableStreamDefaultReader` and `AcquireWritableStreamDefaultWriter` might throw synchronously anyway if either stream is already locked? Shouldn't either all of these throw, or all of these be promises?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/512#pullrequestreview-4377881