Re: [whatwg/streams] Add controller arguments to sink write and close (#538)

domenic approved this pull request.

LGTM with nit on test naming.

> @@ -25,6 +25,38 @@ promise_test(() => {
 }, 'controller argument should be passed to start method');
 
 promise_test(() => {
+  const passedError = new Error('tea and scones');
+  const ws = new WritableStream({
+    write(chunk, controller) {
+      controller.error(passedError);
+    }
+  });
+
+  const writer = ws.getWriter();
+  writer.write('a');
+
+  return writer.closed.catch(r => {
+    assert_equals(r, passedError, 'ws should be errored by passedError');
+  });
+}, 'controller argument should be passed to write method');

Nit: maybe "and should be able to error the stream"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/538#pullrequestreview-4316595