- From: Marvin Hagemeister <notifications@github.com>
- Date: Fri, 14 Oct 2016 09:21:09 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Friday, 14 October 2016 16:21:37 UTC
marvinhagemeister commented on this pull request.
> +
+ return ts.writable.getWriter().close().then(() => {
+ return assert_true(flushCalled, 'closing the writable triggers the transform flush immediately');
+ });
+}, 'TransformStream flush is called immediately when the writable is closed, if no writes are queued');
+
+// TODO
+test(() => {
+ let flushCalled = false;
+ const ts = new TransformStream({
+ transform() {
+ return new Promise(resolve => setTimeout(resolve, 10));
+ },
+ flush() {
+ flushCalled = true;
+ return new Promise(); // never resolves
Thanks, I didn't know that, fixed in latest rebase 👍
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/531
Received on Friday, 14 October 2016 16:21:37 UTC