- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 13 Oct 2016 01:26:54 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
Received on Thursday, 13 October 2016 08:27:43 UTC
annevk commented on this pull request. > @@ -662,6 +662,15 @@ <h4 id=terminology-headers>Headers</h4> <span data-anolis-spec=html>environment settings object</span>). <p>A <span title=concept-request>request</span> has an associated +<dfn title=concept-request-reserved-client data-export data-dfn-for=request>reserved client</dfn> +(null or an <span data-anolis-spec=html>environment</span> or an +<span data-anolis-spec=html>environment settings object</span>). Unless stated otherwise it is null. + +<p>A <span title=concept-request>request</span> has an associated +<dfn title=concept-request-target-client-id data-export data-dfn-for=request>target client id</dfn> +(null or a string). Unless stated otherwise it is null. Can't we just use the empty string here? It's usually better to not change data types if not necessary. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/383#pullrequestreview-4023752
Received on Thursday, 13 October 2016 08:27:43 UTC