Re: [whatwg/streams] Eliminate usages of async_test (#534)

tyoshino commented on this pull request.

lgtm

> @@ -29,40 +24,38 @@ promise_test(t => {
   writer.write('a');
   assert_equals(writer.desiredSize, 0, 'desiredSize should be 0 after writer.write()');
 
-  // Wait and verify that write isn't be called.
-  return delay(100).then(() => {
-    expectWriteCall = true;
-    resolveStartPromise();
-    return writer.ready;
-  });
+  // Wait and verify that write isn't called.
+  return delay(100)
+      .then(() => {
+        expectWriteCall = true;

remove?

>    return delay(100).then(() => {
-    expectCloseCall = true;
+    assert_array_equals(ws.events, [], 'close should not be called until start promise resolves');

remove expectCloseCall from L40

> @@ -209,11 +193,8 @@ async_test(t => {
 
     resolveFirstWritePromise();
 
-    writePromise
-        .then(t.step_func(() => {
-          assert_equals(writeCount, numberOfWrites, `should have called sink's write ${numberOfWrites} times`);
-          t.done();
-        }))
-        .catch(t.step_func(() => assert_unreached('writePromise should not be rejected')));
-  }), 0);
+    return writePromise
+        .then(() =>
+        assert_equals(writeCount, numberOfWrites, `should have called sink's write ${numberOfWrites} times`));

indent with 2 or 4?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/534#pullrequestreview-4010846