Re: [whatwg/streams] Eliminate usages of async_test (#534)

ricea commented on this pull request.



>  
-    writer.ready.then(t.step_func(() => {
-      const writePromise = writer.write('a');
-      let writePromiseResolved = false;
-      assert_not_equals(resolveSinkWritePromise, undefined, 'resolveSinkWritePromise should not be undefined');
+  writer.ready.then(() => {

Yes. This is a bit of a gotcha with promise_test. But at least unlike the gotchas in async_test, it's consistent with how Promises work in general.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/534