Re: [whatwg/streams] Eliminate usages of async_test (#534)

tyoshino commented on this pull request.



> @@ -15,17 +15,11 @@ async_test(t => {
       });
     },
     write(chunk) {
-      t.step(() => {
-        assert_true(expectWriteCall, 'write should not be called until start promise resolves');
-        assert_equals(chunk, 'a', 'chunk should be the value passed to write');
-        t.done();
-      });
+      assert_true(expectWriteCall, 'write should not be called until start promise resolves');
+      assert_equals(chunk, 'a', 'chunk should be the value passed to write');

Hmm, I think we should keep this test async_test. assert_.* methods should be captured by t.step() or they'll be passed to the rejection callback for these underlying sink methods. I see that writer.ready would pass the thrown AssertionError to promise_test() finally, but it's depending on the internals of the WritableStream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/534#pullrequestreview-3845459