Re: [w3c/ServiceWorker] Making a concurrent request for navigations (#920)

@NekR No need for a separate repo, I just saw other comments saying you'd updated bits and I didn't know if you'd updated *that* comment or if it was spread across multiple places. A single gist may have been better. Anyway, here's a review:

Triggering this feature at registration time is confusing as it isn't clear what it's tied to. If my url & scope are the same, but `preflight` has changed, will my service worker be refetched? Will preflights start happening immediately for the active worker, or is the setting tied to subsequent service workers? If I wanted to disable this feature how would I do that? Problem is the code calling `register` is likely cached, so I'd need to update my SW to update that script, then reload the page to change the setting?

It doesn't really mention what `ttl` does.

It doesn't really cover which requests are in `requests`, is it just `<link rel="preload">` and this new preflight thing, or is it *all* fetches in the fetch group?

It doesn't cover what happens if multiple processes read a single response. Do additional reads fail? This is where most of the complexity happens, you'd need some sort of mutex for accessing a response body.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/issues/920#issuecomment-252657496