- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 07 Oct 2016 12:29:00 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Friday, 7 October 2016 19:29:33 UTC
Can you convert the async_tests to promise_tests? async_test is unreliable in general (it runs in parallel instead of sequentially) and ugly to write and read. You can use the delay() helper landing in #526/already in WPTs instead of setTimeout. Otherwise LGTM I guess; given the intentional minimalism there's not too much to review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/527#issuecomment-252340580
Received on Friday, 7 October 2016 19:29:33 UTC